Skip to content

feat: isochrones overlap option, pois from known source#8

Merged
ymarcon merged 6 commits intomainfrom
dev
Nov 5, 2025
Merged

feat: isochrones overlap option, pois from known source#8
ymarcon merged 6 commits intomainfrom
dev

Conversation

@ymarcon
Copy link
Copy Markdown
Member

@ymarcon ymarcon commented Nov 5, 2025

No description provided.

@ymarcon ymarcon requested a review from Copilot November 5, 2025 13:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the isochrones dependency from version 0.3.0 to 0.4.1, which introduces a new dependency (pyogrio) and API changes. The upgrade includes:

  • Adding support for an overlap parameter in isochrone calculations
  • Adding source and cached parameters to POI retrieval for more flexible data sourcing
  • Updating the get_osm_features function calls to use the new bounding_box parameter name and osm_pbf_path parameter
  • Temporarily disabling API key authentication on the /pois endpoint

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pyproject.toml Bumped project version to 0.4.0 and updated isochrones dependency to 0.4.1
poetry.lock Updated lock file with new isochrones version 0.4.1, added pyogrio dependency, and updated resolved reference
api/models/isochrones.py Added source and cached fields to PoisData model, and overlap field to IsochronePoisData model
api/views/isochrones.py Added overlap parameter to isochrone calculation, added source and cached parameters to POI retrieval, and commented out API key security check for /pois endpoint
api/service/pois.py Changed default value of cached parameter from True to False, added source parameter throughout the service methods, and updated get_osm_features calls to use new parameter names (bounding_box and osm_pbf_path)
Comments suppressed due to low confidence (2)

api/service/pois.py:356

  • The _make_area_cache method signature now requires a source parameter (line 367), but this call doesn't provide it, which will cause a TypeError. Pass source=None to match the method signature.
            features = await self._make_area_cache(area)

api/service/pois.py:356

            features = await self._make_area_cache(area)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ymarcon ymarcon merged commit 53038ec into main Nov 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants