Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the isochrones dependency from version 0.3.0 to 0.4.1, which introduces a new dependency (pyogrio) and API changes. The upgrade includes:
- Adding support for an
overlapparameter in isochrone calculations - Adding
sourceandcachedparameters to POI retrieval for more flexible data sourcing - Updating the
get_osm_featuresfunction calls to use the newbounding_boxparameter name andosm_pbf_pathparameter - Temporarily disabling API key authentication on the
/poisendpoint
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Bumped project version to 0.4.0 and updated isochrones dependency to 0.4.1 |
| poetry.lock | Updated lock file with new isochrones version 0.4.1, added pyogrio dependency, and updated resolved reference |
| api/models/isochrones.py | Added source and cached fields to PoisData model, and overlap field to IsochronePoisData model |
| api/views/isochrones.py | Added overlap parameter to isochrone calculation, added source and cached parameters to POI retrieval, and commented out API key security check for /pois endpoint |
| api/service/pois.py | Changed default value of cached parameter from True to False, added source parameter throughout the service methods, and updated get_osm_features calls to use new parameter names (bounding_box and osm_pbf_path) |
Comments suppressed due to low confidence (2)
api/service/pois.py:356
- The
_make_area_cachemethod signature now requires asourceparameter (line 367), but this call doesn't provide it, which will cause a TypeError. Passsource=Noneto match the method signature.
features = await self._make_area_cache(area)
api/service/pois.py:356
- Call to method PoisService._make_area_cache with too few arguments; should be no fewer than 2.
features = await self._make_area_cache(area)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.