-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial version of Julia support #654
initial version of Julia support #654
Conversation
After PR #652 is merged with the Test diagnostic code should be added in tests/integration/test_diagnostic_run.py CircleCI configuration (in .circleci/config.yml) should be updated so 'python2_install', 'python3_install' and 'develop' and 'conda_install' installation test jobs also install julia. |
@fdiblen can you please finalize this PR? We need to merge it soon since other PRs depends on it. |
@mattiarighi I think the R support is more or less ready. I will work on this now to finalize it. |
And don't forget to update the conda build in meta.yml. |
I would like to specify a recent julia version (1.0.2) in |
@jhardenberg You can specify the version in environment.yml and meta.yml. Make sure to do it in both files. It is fine to do it in this branch. I agree that we need at least version 1. I strongly prefer to only install packages from the standard package repository, because we then we can expect the quality to be reasonable. Installing directly from github is not allowed for other languages either for this reason. |
In principle I totally agree, but it could be a feature which is useful for development. There is no need then to actually include any packages from github in The reason is actually my RainFARM package ( https://github.com/jhardenberg/RainFARM.jl ) which in the past I never bothered to release. I will do it very soon, but I need a few days to complete the documentation first. In the meantime we need it urgently for Magic. |
Yes, that should be fine. You can then create a release and change it back before it is merged into the version2_development branch.
Having the capability will make people think that it is ok to use it and encourage pull requests that make esmvaltool unreliable. If you need a different version of a package for development, you can install it manually. The final pull request should depend on released packages. |
Should the directory I have locally done a merge of the latest |
Adding julia 1.0 to the environment requirements seems to conflict with the requirement for gcc which was added with the R support. In fact conda info reveals that |
There is no gcc package in #631. Compilation of R packages need c/c++ compiler. To compile these packages I used r-rcpp package. When the lintr was being added I also raised an issue about gcc. Maybe we should remove it and add the one Julia needs. |
Please see this issue #734 The conda gcc package is deprecated and should be replaced by these three packages:
|
I repeat this question: Should the directory esmvaltool/Julia not be in esmvaltool/install/Julia for consistency with R ? |
@jhardenberg Yes, it should. We had a lot of changes in 'R support branch' since we started Julia support. As you mentioned, it should be moved to esmvaltool/install/Julia. Please go ahead. |
Ok, done in 802030c |
@fdiblen what is the status of this PR? |
I will probably finish this sometime in the next month or so. |
I suggest to stick with julia 0.6.1 for now. While developing the RainFARM diagnostic (see #619 ) and trying to switch to the latest julia v1.0.3 I found that the JuliaCall R library is not compatible with julia >= 1.0.0 from conda-forge. The problem I run into is discussed here JuliaLang/julia#29720 , and has something to do with the conda-forge julia build. I fixed |
Builds are failing because lintr does not install. In #619 I was able to solve the problem by adding r-curl and r-igraph to environment.yml |
See issue #624