Skip to content

Change all instances for max distance to True and 150 #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rt-earthscope wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change all instances for max distance to True and 150 #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/INDEX.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ pre-filtering configuration

- `max_distance_from_center` (dict): Configuration for filtering shots based on distance from array center.
- `enabled` (bool): If `True`, enables distance-based filtering. Defaults to `False`.
- `max_distance_m` (float): Maximum distance threshold in meters. Defaults to `500.0`.
- `max_distance_m` (float): Maximum distance threshold in meters. Defaults to `150.0`.
- `description` (str): Filter description: "Filter shots beyond maximum distance from array center".

- `ping_replies` (dict): Configuration for filtering based on acoustic ping replies.
Expand Down
4 changes: 2 additions & 2 deletions app/tests/pre-proc-manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ garposConfig:
enabled: false
max_residual_mm: 8
max_distance_from_center:
enabled: false
max_distance_m: 500.0
enabled: true
max_distance_m: 150.0
ping_replies:
enabled: false
min_replies: 1
Expand Down
2 changes: 1 addition & 1 deletion dev/DEV_GARPOS_QUIRKS_DEMO.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def main():

filter_config = {
"pride_residuals": {"enabled": False, "max_residual_mm": 8},
"max_distance_from_center": {"enabled": False, "max_distance_m": 500.0},
"max_distance_from_center": {"enabled": True, "max_distance_m": 150.0},
"ping_replies": {"enabled": False, "min_replies": 1},
"acoustic_filters": {"enabled": True, "level": "OK"}
}
Expand Down
2 changes: 1 addition & 1 deletion dev/dev_cloudpath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def main():

filter_config = {
"pride_residuals": {"enabled": False, "max_residual_mm": 8},
"max_distance_from_center": {"enabled": False, "max_distance_m": 500.0},
"max_distance_from_center": {"enabled": True, "max_distance_m": 150.0},
"ping_replies": {"enabled": False, "min_replies": 1},
"acoustic_filters": {"enabled": True, "level": "OK"},
}
Expand Down
4 changes: 2 additions & 2 deletions dev/notebooks/GARPOS_QURIKS_DEMO.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
},
{
"cell_type": "code",
"execution_count": 13,
"execution_count": null,
"id": "acf63854",
"metadata": {},
"outputs": [],
Expand All @@ -44,7 +44,7 @@
"\n",
"filter_config = {\n",
" \"pride_residuals\": {\"enabled\": False, \"max_residual_mm\": 8},\n",
" \"max_distance_from_center\": {\"enabled\": False, \"max_distance_m\": 500.0},\n",
" \"max_distance_from_center\": {\"enabled\": True, \"max_distance_m\": 500.0},\n",
" \"ping_replies\": {\"enabled\": False, \"min_replies\": 1},\n",
" \"acoustic_filters\": {\"enabled\": True, \"level\": \"OK\"}\n",
"}\n",
Expand Down
4 changes: 2 additions & 2 deletions examples/geolab/get_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
"description": "Filter based on GNSS positioning residuals",
},
"max_distance_from_center": {
"enabled": False,
"max_distance_m": 500.0,
"enabled": True,
"max_distance_m": 150.0,
"description": "Filter shots beyond maximum distance from array center",
},
"ping_replies": {
Expand Down
2 changes: 1 addition & 1 deletion src/es_sfgtools/config/shotdata_filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

default_filter_config = {
"pride_residuals": {"enabled": False, "max_residual_mm": 8},
"max_distance_from_center": {"enabled": False, "max_distance_m": 150.0},
"max_distance_from_center": {"enabled": True, "max_distance_m": 150.0},
"ping_replies": {"enabled": False, "min_replies": 3},
"acoustic_filters": {"enabled": False, "level": "OK"}
}
Expand Down
2 changes: 1 addition & 1 deletion src/es_sfgtools/prefiltering/schemas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class PingRepliesFilterConfig(BaseModel):

class MaxDistFromCenterConfig(BaseModel):
enabled: bool = Field(
False, description="Whether to enable max distance from center filtering"
True, description="Whether to enable max distance from center filtering"
)
max_distance_m: float = Field(
150.0,
Expand Down