Skip to content

fixes v2 metadata#13

Merged
lazarusA merged 3 commits into
mainfrom
la/fix_v2_metadata
May 18, 2026
Merged

fixes v2 metadata#13
lazarusA merged 3 commits into
mainfrom
la/fix_v2_metadata

Conversation

@lazarusA

Copy link
Copy Markdown
Member

closes #12

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements on-the-fly synthesis of .zmetadata for unconsolidated Zarr v2 stores, enabling hierarchy discovery for HTTP clients without requiring directory listings. It also introduces path traversal protection and support for HEAD requests. Review feedback identifies critical runtime issues, specifically that the 3-argument call to Zarr.consolidate_metadata and the access to Zarr.JSON will likely fail. Additionally, the reviewer suggested including Content-Length in HEAD responses for synthesized metadata and optimizing JSON serialization by removing indentation.

Comment thread src/serve_zarr.jl
Comment thread src/serve_zarr.jl
Comment thread src/serve_zarr.jl Outdated
@lazarusA
lazarusA merged commit 736ed56 into main May 18, 2026
9 checks passed
@lazarusA
lazarusA deleted the la/fix_v2_metadata branch June 9, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

it looks like not all zarr directories are read properly

1 participant