fixes v2 metadata#13
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements on-the-fly synthesis of .zmetadata for unconsolidated Zarr v2 stores, enabling hierarchy discovery for HTTP clients without requiring directory listings. It also introduces path traversal protection and support for HEAD requests. Review feedback identifies critical runtime issues, specifically that the 3-argument call to Zarr.consolidate_metadata and the access to Zarr.JSON will likely fail. Additionally, the reviewer suggested including Content-Length in HEAD responses for synthesized metadata and optimizing JSON serialization by removing indentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #12