Skip to content

Replace everything by missing if gdalfile throws error#121

Merged
felixcremer merged 15 commits into
mainfrom
fc/tiferrors
Nov 19, 2025
Merged

Replace everything by missing if gdalfile throws error#121
felixcremer merged 15 commits into
mainfrom
fc/tiferrors

Conversation

@felixcremer

Copy link
Copy Markdown
Collaborator

This will allow to read Sentinel-1 data even though one single time step is not available.

This also saves the rqatrend result locally and rechunks it into S3.

Felix Cremer and others added 8 commits November 17, 2025 15:59
…e data

This will allow to read Sentinel-1 data even though one single time step is not available.
With this we can save the RQA trend data in UInt8 data and can apply the threshold on that.
@felixcremer

Copy link
Copy Markdown
Collaborator Author

This also reintroduces the classification into UInt8 classes.

The tests are passing locally.

This is actually not needed, because we are trying to keep the Path type and don't have to recast it.
@felixcremer
felixcremer requested a review from meggart November 18, 2025 14:18
Comment thread src/main.jl Outdated
Comment thread src/rqatrend.jl
@@ -49,10 +48,30 @@ rqatrend(xout, xin, thresh)
Compute the RQA trend metric for the non-missing time steps of xin, and save it to xout.
`thresh` specifies the epsilon threshold of the Recurrence Plot computation
"""

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add to the docs that a value between 0 and 254 is returned and 255 corresponds to missing. Also, the kwargs lowerbound and upperbound are not documented

Comment thread src/rqatrend.jl Outdated
@codecov

codecov Bot commented Nov 18, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.45455% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.55%. Comparing base (d0863a2) to head (0a6f428).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/main.jl 54.83% 14 Missing ⚠️
src/auxil.jl 71.42% 4 Missing ⚠️
src/rqatrend.jl 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   56.76%   66.55%   +9.78%     
==========================================
  Files           6        6              
  Lines         266      287      +21     
==========================================
+ Hits          151      191      +40     
+ Misses        115       96      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@felixcremer
felixcremer merged commit 28e0223 into main Nov 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants