Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE-12] Create fpb-diffs.yml workflow #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

davorpa
Copy link
Member

@davorpa davorpa commented Sep 19, 2022

Description

This workflow runs the parser over current commit of https://github.com/EbookFoundation/free-programming-books project twice:

  1. Using the parser at the base commit (aka main)
  2. Using the parser at the current commit of the pull_request (aka MERGE_HEAD commit)

Usefull to see how many changes (aka git diff) in fpb.json file introduces a change in the parser. It could act as pseudo-linter.

To mantain it simple I post the results as GitHub Actions summary, but it could be posted as PR comment too.

Context

WITHOUT CHANGES WITH CHANGES
image image

NOTE:

If this workflow is accepted needs enable GHA environment. Copy same settings from FPB. It seems to be disabled at this moment

@davorpa davorpa marked this pull request as ready for review September 19, 2022 16:18
@davorpa davorpa changed the title Create fpb-diffs.yml workflow [FEATURE-12] Create fpb-diffs.yml workflow Sep 19, 2022
@eshellman
Copy link
Contributor

Usefull to see how many changes (aka git diff) in fpb.json file introduces a change in the parser. It could act as pseudo-linter.

Who's going to look at it?

@davorpa
Copy link
Member Author

davorpa commented Sep 24, 2022

Usefull to see how many changes (aka git diff) in fpb.json file introduces a change in the parser. It could act as pseudo-linter.

Who's going to look at it?

As you said in #11 (comment) it was useful

Maybe a bit hidden but is responsability of whom review see the changes, or ar least have any tool to automatize it or give facilities.

Do you prefer notify as PR comment or leave it as is with a GHA summary (see runs)?

image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants