[DMS-301] E2E testing for OpenSearch queries #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Test Results583 tests +13 555 ✅ +10 2m 54s ⏱️ +9s Results for commit 3e25327. ± Comparison against base commit 762f0ec. This pull request removes 11 and adds 24 tests. Note that renamed tests count towards both.This pull request skips 2 and un-skips 1 tests.♻️ This comment has been updated with latest results. |
CSR2017
commented
Sep 5, 2024
| @@ -103,24 +67,6 @@ Feature: Read a Descriptor | |||
| [] | |||
| """ | |||
There was a problem hiding this comment.
Comment from @stephenfuqua : @msilesgap when we merge this PR, some of the scenarios will move. We will need to update the spreadsheet accordingly.
Why? Suganya and I discussed and agreed that this would simplify our ability to only reset OpenSearch between tests if really needed. Thus we want to keep all of the OpenSearch-related tests together in one place. We thought about using tags, but there is also a setup step that needs to happen ("background"), and we did not want that setup step scattered in many different places.
CSR2017
commented
Sep 5, 2024
| @@ -0,0 +1,74 @@ | |||
| Feature: Query String handling for GET requests for Descriptor Queries | |||
There was a problem hiding this comment.
@msilesgap
All the descriptors tests with query string are moved to this new file
stephenfuqua
approved these changes
Sep 6, 2024
* Rename a bunch of files * Refactor the docker compose scripts * Appsettings refactor * Support for rebuilding the local image * No longer need this file
stephenfuqua
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.