Open
Conversation
Add bitcoin cash chain id Add zero address constant Use correct fetch Reaplce switch/case with if for Zano special case
The plugin isn't handling tokenId or decimals correctly. It just kind of worked for bitcoin because the number of decimals matched on both sides of the swap. For tokenId, only the fromWallet was used so the plugin is broken if the swap goes from token->token.
This is an arbitrary limitation. Other swaps should work (ie. bitcoin to ethereum btcx token) but they are untested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
noneNote
Medium Risk
Adds new chain support and new EVM transaction/approval flows in
bridgeless, which could affect swap amounts, memos, and order tracking if encoding or decimal-scaling is incorrect.Overview
Expands the
bridgelessswap plugin to support additional source chains (Bitcoin Cash, Ethereum, BNB Chain) for swaps that involve Zano, including new chain-id mappings and routing.Adds EVM deposit support by encoding
depositNative/depositERC20call data viaethers, generating ERC20 approvalpreTxswhen needed, and adjustingorderIdoutput-index handling for token deposits.Updates quote amount math to account for differing token decimals across chains via new
scaleNativeAmount(with tests), and generalizes receiver address formatting (Zano address hex-encoding vs passthrough for others).Written by Cursor Bugbot for commit fc0bb79. This will update automatically on new commits. Configure here.