Skip to content

Sam/quote order flows #5703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 34 commits into
base: develop
Choose a base branch
from
Open

Sam/quote order flows #5703

wants to merge 34 commits into from

Conversation

samholmes
Copy link
Contributor

@samholmes samholmes commented Aug 15, 2025

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)
Simulator Screenshot - iPhone 16 Pro (18 0) - gui three - 2025-08-15 at 16 11 48 Simulator Screenshot - iPhone 16 Pro (18 0) - gui three - 2025-08-15 at 16 12 02 Simulator Screenshot - iPhone 16 Pro (18 0) - gui three - 2025-08-15 at 16 23 55 Simulator Screenshot - iPhone 16 Pro (18 0) - gui three - 2025-08-15 at 16 12 07

This is an attempt to get the agent to automatically document lessons
learned to the docs/ directory. This way conventions are maintained and
over time as the agent is course corrected.
- Create docs/localization-guidelines.md with mandatory UI string localization rules
- Create docs/component-styling-guidelines.md with styled HOC usage patterns
- Update AGENTS.md with Documentation section indexing all docs/ files
- Add rule requiring all docs/ markdown files to be indexed in AGENTS.md
- Add localized strings for TradeRegionSelectScene to en_US.ts
This file contains run configuration such as RN_SIMULATOR and RN_PORT
to be used by a rn-ios script. This is for development purposes
This is a consistent card design for the new fiat buy UI.
This component can be used with the PaymentOptionCard as the
renderRight prop.

This is apart of the new fiat buy UI design.
Initial architecture design.
Include plugin IDs in React Query key so quotes refetch when
region/currency/wallet changes affect available plugins. Simplify
queryFn to always check current plugins while reusing valid cached
quotes.
@@ -53,7 +53,7 @@ if (ENV.SENTRY_ORGANIZATION_SLUG.includes('SENTRY_ORGANIZATION')) {
}

// Uncomment the next line to remove popup warning/error boxes.
// LogBox.ignoreAllLogs()
LogBox.ignoreAllLogs()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Unintended Debug Code Hides Critical Errors

LogBox.ignoreAllLogs() is uncommented, which suppresses all console warnings and errors. This looks like accidentally committed debug code that can hide important issues and make debugging difficult, especially in production.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant