fix: restore update-typescript-go workflow#180
Closed
xesrevinu wants to merge 1 commit intoEffect-TS:mainfrom
Closed
fix: restore update-typescript-go workflow#180xesrevinu wants to merge 1 commit intoEffect-TS:mainfrom
xesrevinu wants to merge 1 commit intoEffect-TS:mainfrom
Conversation
Contributor
|
I'm sorry I noticed the PR after I have done the fix, thanks for it anyway! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the automatic
update-typescript-goworkflow after the latest upstreamtypescript-goupdate.This PR:
_patches/001-cmd-tsgo-main.patchagainst the current upstreamcmd/tsgo/main.gotypescript-gosubmodule toee4225a856389fc94c8ce4a5fd9af771dbbc2c0bflake.nix/flake.lockwith the updated upstream commit_tools/update-flake-vendor-hash.shfor local/staged submodule refreshes and emptyNIX_BUILD_ARGSWhy
The scheduled workflow started failing in
pnpm setup-repo --cibecause_patches/001-cmd-tsgo-main.patchno longer applied after upstream addedinternal/coreimports andcore.ApplyDebugStackLimit()tocmd/tsgo/main.go.Validation
Ran locally:
pnpm setup-repo --cipnpm checkpnpm testnix build .#effect-tsgopnpm lintstill reports pre-existingmodernizediagnostics unrelated to this change.