Skip to content

fix TS2683 false positives in nested Effect.gen#183

Merged
mattiamanzati merged 1 commit intomainfrom
fix/issue179-effect-gen-this
May 6, 2026
Merged

fix TS2683 false positives in nested Effect.gen#183
mattiamanzati merged 1 commit intomainfrom
fix/issue179-effect-gen-this

Conversation

@mattiamanzati
Copy link
Copy Markdown
Contributor

Summary

  • avoid eager data-first signature analysis for problematic Effect contexts that can destabilize this typing in Effect.gen({ self: this }, ...)
  • remove the unused eager EffectGenCallResult return-type caching and keep coverage by asserting through native effect-v4 fixtures and baselines
  • add regression coverage for all reported #179 examples under strict mode, including nested generic calls, callback thunks, callee this, .pipe() chains, and curried wrappers

Fixes #179.

Validation

  • pnpm setup-repo
  • pnpm lint
  • pnpm check
  • pnpm test

@mattiamanzati mattiamanzati merged commit de8fb53 into main May 6, 2026
4 checks passed
@mattiamanzati mattiamanzati deleted the fix/issue179-effect-gen-this branch May 6, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More TS2683 false positive cases with Effect.gen({ self: this }, ...)

1 participant