Skip to content

test fourslash effect mount markers#186

Merged
mattiamanzati merged 4 commits into
mainfrom
fix/fourslash-effect-mount-markers
May 7, 2026
Merged

test fourslash effect mount markers#186
mattiamanzati merged 4 commits into
mainfrom
fix/fourslash-effect-mount-markers

Conversation

@mattiamanzati
Copy link
Copy Markdown
Contributor

Summary

  • mount real Effect packages in fourslash tests when @effect-v3 or @effect-v4 markers are present, even without a preexisting from \"effect\" import
  • add unit coverage for the mount trigger behavior in etstesthooks
  • verify Effect auto-import namespace behavior against the real mounted package for effect/Effect and effect/testing/TestClock

Validation

Passed:

  • go test ./etstesthooks -count=1 -v
  • go test ./internal/effecttest -run 'TestAutoImportEffectStyleConsistency_(namespace|topLevelNamedReexportsIgnore|topLevelNamedReexportsFollow|testClockWithNamespace)' -count=1 -v

Blocked on current main after pnpm setup-repo:

  • pnpm lint
  • pnpm check
  • pnpm test

Those full-repo commands currently fail due an unrelated generated shim / patched typescript-go sync issue on main, not from this change.

@mattiamanzati mattiamanzati merged commit 54da1c5 into main May 7, 2026
5 checks passed
@mattiamanzati mattiamanzati deleted the fix/fourslash-effect-mount-markers branch May 7, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant