ci: fix failing tests and build related to pKa-ANI dependencies#443
Conversation
# Put this after setup-python
- name: Install uv and activate environment
uses: astral-sh/setup-uv@v7
with:
# Use uv venv to activate a venv ready to be used by later steps
activate-environment: "true"
|
|
@kiyoon I see, so sorry did not read the astral guide when you shared it the first time. I have updated the python-package.yml file to follow what you have provided |
|
I think the environment problem is gone, but there's a problem with the test that the files not being able to be fetched. I don't know what happened |
|
@kiyoon I think there were two issues - one was that in pkaani_test.py the PKAANI_TEST_DIR was set to |
|
Is there a way to get it to freshly download the dependencies? I updated pkaani on pyPI but it seems to still be showing the old version in the build pipeline installation: |
|
@kiyoon added the --no-cache option to uv so it pulls the latest pyPI version of pkaani, should work this time (fingers crossed) |
|
@kiyoon still defaulting to |
|
It's probably due to the dependency issue. If you run EDIT: About the output below When you try to install pkanni in the environment with pdb2pqr without it, it forces to install nunpy v1. So maybe I think that could be the culprit. In any case, we need to avoid numpy v1 for future compatibility because there are already many packages that don't support it |
|
@kiyoon Thank you for the suggestion, you were totally right. I removed the numpy<2 pin from the pyPI pkaani, it is not needed for the pkaani import and usage in pdb2pqr. Can we try again? I think now this should work - at least it worked when I tested it locally just now. When the modules load now |
|
if it works, you may remove --upgrade --refresh --no-cache so it doesn't confuse future contributors |
|
@kiyoon it worked finally! took out those options from the uv pip command. |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses linting issues in the pKa-ANI integration tests and modernizes the CI/CD pipeline to use uv for faster, more reliable dependency management with CPU-only PyTorch installation.
- Reformatted test parametrization decorators to follow proper Python style guidelines
- Fixed relative path for pKa-ANI test data directory
- Updated GitHub Actions workflow to use
uvpackage manager with CPU-only PyTorch backend - Upgraded GitHub Actions to their latest versions (checkout@v5, upload-artifact@v5)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/pkaani_test.py | Corrected test data directory path and reformatted pytest parametrize decorators for better readability |
| tests/common.py | Removed extraneous blank lines for cleaner code formatting |
| .github/workflows/python-package.yml | Modernized CI pipeline by integrating uv package manager, updated action versions, and configured CPU-only PyTorch installation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Made an edit on @kiyoon's recommendation to get pdb2pqr[pkaani] version with cpu torch to install, hopefully now this build pipeline will work