-
Notifications
You must be signed in to change notification settings - Fork 953
migration from poetry to uv #8249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
madelinevibes
merged 13 commits into
ElementsProject:master
from
king-11:king-11/migrate-uv
Aug 11, 2025
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
49eeb31
refactor: pyproject.toml poetry to uv + hatch
king-11 3cd7911
feat: add __init__.py in packages
king-11 3b79d65
feat: add pytest config
king-11 d13e6c4
feat: replace poetry with uv for dependency management
king-11 da4c9b5
fix: macOS for grpico-tools
king-11 d117d35
fix: flake8 lint rules
king-11 e7ff2ea
feat: replace poetry with uv in Makefiles
king-11 7c6a48e
feat: update release pipeline
king-11 d736fb1
chore: update docs for uv
king-11 46c065d
chore: add poetry for reckless
king-11 52832ec
chore: add libffi
king-11 2d49a4d
fix: replace deprecated flask.escape with markupsafe.escape
king-11 873cd0e
fix: coincurve build issue
king-11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,21 +25,32 @@ jobs: | |
sudo mv bitcoin-${BITCOIND_VERSION}/bin/* /usr/local/bin | ||
rm -rf bitcoin-${BITCOIND_VERSION}-${TARGET_ARCH}.tar.gz bitcoin-${BITCOIND_VERSION} | ||
|
||
- name: Set up Python 3.10 | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: "3.10" | ||
|
||
- name: Install uv | ||
uses: astral-sh/setup-uv@v5 | ||
|
||
- name: Install dependencies | ||
run: | | ||
export PATH="/usr/local/opt:/Users/runner/.local/bin:/opt/homebrew/bin/python3.10/bin:$PATH" | ||
|
||
brew install gnu-sed [email protected] autoconf automake libtool protobuf | ||
python3.10 -m pip install -U --user poetry==1.8.0 wheel pip mako | ||
python3.10 -m poetry install | ||
brew install gnu-sed autoconf automake libtool protobuf openssl | ||
|
||
# https://github.com/grpc/grpc/issues/31737#issuecomment-1323796842 | ||
export GRPC_PYTHON_BUILD_SYSTEM_OPENSSL=1 | ||
export GRPC_PYTHON_BUILD_SYSTEM_ZLIB=1 | ||
uv sync --all-groups | ||
|
||
- name: Build and install CLN | ||
run: | | ||
export CPATH=/opt/homebrew/include | ||
export LIBRARY_PATH=/opt/homebrew/lib | ||
|
||
python3.10 -m poetry run ./configure --disable-valgrind --disable-compat | ||
python3.10 -m poetry run make | ||
uv run ./configure --disable-valgrind --disable-compat | ||
uv run make | ||
|
||
- name: Start bitcoind in regtest mode | ||
run: | | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we even still use the system python? I think
uv
will pull down a standalone python binary, completely ignoring the system one.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think uv will only do it if we explicitly ask it to create python venv with a different python version that what is available in system