Skip to content

fuzz-tests: get rid of magic numbers in fuzz-hsm_encryption.c #8595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fuzz-tests: get rid of magic numbers in fuzz-hsm_encryption.c #8595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d94a11
fuzz-tests: get rid of magic numbers in `fuzz-hsm_encryption.c`
Jun 5, 2025
8cea2f3
fuzz-tests: Add coverage-increasing inputs to seed corpora
Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/fuzz/corpora/fuzz-hsm_encryption/23310b00d98159b5b169b2b919f4af986233e4a0
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
QQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQ-
Binary file added tests/fuzz/corpora/fuzz-hsm_encryption/25172a8f2d48f9081b884ed5066cb4fc41a7099d
View file
Open in desktop
Binary file not shown.
12 changes: 6 additions & 6 deletions tests/fuzz/fuzz-hsm_encryption.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,18 @@ void init(int *argc, char ***argv)

void run(const uint8_t *data, size_t size)
{
/* 4294967295 is crypto_pwhash_argon2id_PASSWD_MAX. libfuzzer won't
* generate inputs that large in practice, but hey. */
if (size > 32 && size < 4294967295) {
/* LibFuzzer won't generate inputs larger than
* crypto_pwhash_argon2id_PASSWD_MAX in practice, but hey. */
if (size > sizeof(struct secret) && size < crypto_pwhash_argon2id_PASSWD_MAX) {
struct secret *hsm_secret, decrypted_hsm_secret, encryption_key;
char *passphrase;
struct encrypted_hsm_secret encrypted_secret;
const char *emsg;

/* Take the first 32 bytes as the plaintext hsm_secret seed,
* and the remaining ones as the passphrase. */
hsm_secret = (struct secret *)tal_dup_arr(NULL, u8, data, 32, 0);
passphrase = to_string(NULL, data + 32, size - 32);
hsm_secret = (struct secret *)tal_dup_arr(NULL, u8, data, sizeof(struct secret), 0);
passphrase = to_string(NULL, data + sizeof(struct secret), size - sizeof(struct secret));

/* A valid seed, a valid passphrase. This should not fail. */
assert(!hsm_secret_encryption_key_with_exitcode(passphrase, &encryption_key, &emsg));
Expand All @@ -35,7 +35,7 @@ void run(const uint8_t *data, size_t size)
decrypted_hsm_secret.data,
sizeof(decrypted_hsm_secret.data)));

tal_free(hsm_secret);
discard_key(hsm_secret);
tal_free(passphrase);
}
}
Loading