Feature/xpay payment description #8784
Conversation
Nazarevsky
force-pushed
the
feature/xpay-payment-description
branch
from
219da3a to
c15a836
Compare
Nazarevsky
force-pushed
the
feature/xpay-payment-description
branch
from
13a8ffe to
644563e
Compare
Changelog-Added: Add 'payer-note' field to the 'xpay' RPC call.
Nazarevsky
force-pushed
the
feature/xpay-payment-description
branch
from
644563e to
51e5ed7
Compare
There was a problem hiding this comment.
@Nazarevsky Thanks for the PR! Since this is your first contribution, I’m being a bit more nitpicky about commit structure. Even if this one doesn’t end up being merged for the reason below, this review should be useful as a reference for future PRs.
That said, I wanted to better understand whether this PR serves its intended purpose. Don’t the existing invoice.description and fetchinvoice.payer_note already cover this use case? A node can already inspect these via listinvoices. How is the payer_note sent via xpay received on the other node? Adding @Lagrang3 in case I’ve missed anything.
| from pyln.grpc import node_pb2 as node__pb2 | ||
|
|
||
| GRPC_GENERATED_VERSION = '1.75.1' | ||
| GRPC_GENERATED_VERSION = '1.76.0' |
There was a problem hiding this comment.
The CI is currently failing due to version mismatch in your grpcio. Please downgrade your local grpcio (uv pip install grpcio==1.75.1).
| const char **layers; | ||
| u32 *maxdelay; | ||
| unsigned int *retryfor; | ||
| const char *payer_note; |
There was a problem hiding this comment.
nit: To keep the formatting consistent and avoid tabs/spaces alignment issues (especially between editors and the GitHub UI), could we format this to match the existing tab-based style?
| json_add_string(req->js, "bip353", xparams->bip353); | ||
| return send_outreq(req); | ||
| if (xparams->bip353) | ||
| json_add_string(req->js, "bip353", xparams->bip353); |
There was a problem hiding this comment.
Mismatched alignment.
2 participants
Resolves #8514
According to Bolt12, Bolt12 invoices support providing descriptions (
payer_notefield). The same field is added to the 'xpay' RPC call. Also, updated schema and added a test case.Important
26.04 FREEZE March 11th: Non-bugfix PRs not ready by this date will wait for 26.06.
RC1 is scheduled on March 23rd
The final release is scheduled for April 15th.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
tools/lightning-downgrade