common: fix ubsan trigger in param test. #8815
Merged
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
fix-ubsan-run-param
branch
from
868b6ab to
533cec4
Compare
``` common/test/run-param.c:381:8: runtime error: applying zero offset to null pointer SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior common/test/run-param.c:381:8 ``` Probably because CI now on 24.04, so more recent clang. But the test really does want to see what happens when the callback is NULL, so workaround. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
fix-ubsan-run-param
branch
from
533cec4 to
32db9dc
Compare
Collaborator
|
@rustyrussell Should we increase the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably because CI now on 24.04, so more recent clang.
Changelog-None