[10.0][MIG][BR001139][T23297]Migrated Project Completion report from v8 to v10#194
Conversation
| activity_stage_id = fields.Many2one( | ||
| 'project.task.type', 'Stage', | ||
| readonly=True, help="Activity Stage") | ||
| # FIXME if BR resource UoM is not hours, `qty` needs to be converted |
There was a problem hiding this comment.
Can you take care of this too?
There was a problem hiding this comment.
Do I need to convert the Day(s) uom only or should convert Unit(s) as well into Hour(s)?
@elicoidal @seb-elico
There was a problem hiding this comment.
@elicoidal it's a tricky one, better to not fix it for now since it might have a huge impact on the performance
@YogeshMahera-SerpentCS please leave the FIXME, we'll fix it later
| <?xml version="1.0" encoding="utf-8"?> | ||
| <openerp> | ||
| <odoo> | ||
| <data> |
There was a problem hiding this comment.
remove if noupdate is absent
seb-elico
left a comment
seb-elico
left a comment
There was a problem hiding this comment.
Missing UT, other than that LGTM
|
@seb-elico This module related report so Is that require UT? |
|
@yogesh Yes, we need to make sure that the computation done by the report is correct |
|
@YogeshMahera-SerpentCS please cherry-pick a5b65c4 (bug fix of the v8 report) |
|
@seb-elico I have added basic test-cases but not complete whole SQL query computation. |
|
@YogeshMahera-SerpentCS can you please merge the latest commits from |
|
@seb-elico Could you please review it |
… 10.0-MIG-project_completion_report
|
@seb-elico Could you please review it |
|
@YogeshMahera-SerpentCS @elicoidal Pending merge of #187 to build Travis |
|
@YogeshMahera-SerpentCS Instead of creating all the UT data in the UT, you should use the demo data created by this module and its parent modules. For instance, there are multiple BRs/Projects/Tasks/TMS in the demo data. You could use them for the UT. Also, you can create some additional demo data for this module and use it in the UT. If unclear, check with @victormartinelicocorp |
|
Travis is red @YogeshMahera-SerpentCS @seb-elico |
… 10.0-MIG-project_completion_report
|
@seb-elico Travis is red due to ParseError: "External ID not found in the system: portal.partner_demo_portal" while parsing /home/travis/OCB-10.0/addons/project_issue/data/project_issue_demo.xml:36, near
|
YogeshMahera-SerpentCS
force-pushed
the
10.0-MIG-project_completion_report
branch
from
9b3e4e6 to
8e37daa
Compare
| 'user_id': fields.many2one('res.users', 'User', readonly=True), | ||
| 'project_id': fields.many2one( | ||
| 'project.project', 'Project', readonly=True), | ||
| 'project_state': fields.char( |
There was a problem hiding this comment.
@Miya609 seems like this field has been forgotten during migration to v10, please add it back
FYI it's here in v8 new API:
https://github.com/Elico-Corp/odoo-addons/blob/8.0/project_completion_report/report/project_completion_report.py#L31
This is the view:
https://github.com/Elico-Corp/odoo-addons/blob/8.0/project_completion_report/report/project_completion_report_view.xml#L15
|
@lonelysun Please make sure all latest commits of v8 report are included in this PR 👍 |
|
@seb-elico I tend to think we should close this PR |
3 participants
Migrated Project Completion Report from v8 to v10
hr.analytic.timesheet --> account.analytic.lineproject.task.work --> account.analytic.lineproject_timesheet --> hr_timesheet@elicoidal @seb-elico @victormartinelicocorp