Skip to content

[ADD][BR1187][T24354]timesheet_activity_report_improve#211

Open
lonelysun wants to merge 3 commits intoElico-Corp:10.0from
lonelysun:timesheet_activity_report_improve
Open

[ADD][BR1187][T24354]timesheet_activity_report_improve#211
lonelysun wants to merge 3 commits intoElico-Corp:10.0from
lonelysun:timesheet_activity_report_improve

Conversation

@lonelysun
Copy link

replace #204

@@ -33,9 +33,9 @@ class TimesheetReport(models.Model):
product_id = fields.Many2one('product.product', 'Product', readonly=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this file should be here?

:alt: License: AGPL-3

=================================
Timesheet Activity Report Improve
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timesheet completion report
module name timesheet_activity_completion_report

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elicoidal
Actually the BR never mentioned to create a separate module. The improvement must be done in the existing module (simply increment version number...).

@lonelysun
Please arrange refactoring

Credits
=======

Images
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this section (only for OCA modules)

@@ -0,0 +1,5 @@
# -*- coding: utf-8 -*-
# Copyright 2015-2017 Elico corp (https://www.elico-corp.com)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need copyright in init.py files

{
'name': 'Timesheet Activities Report',
'version': '10.0.1.1.0',
'category': 'Human Resources',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add Project Management

@@ -0,0 +1,41 @@
# -*- coding: utf-8 -*-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name

_inherit = 'timesheet.activity.report'

br_master_project = fields.Many2one(
'project.project', string='BR Master Pro.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pro. -> Project

)
department_id = fields.Many2one('hr.department', string='Department')

def _select(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seb-elico please review this part

<xpath expr='//div[@name="buttons"]/button[1]' position='before'>
<button class="oe_inline oe_stat_button"
type="object" name="br_open_tms_activity_report"
icon="fa-tasks" string="TMS Com. Rep">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TMS Completion Report

<xpath expr='//button[@name="toggle_active"]' position='before'>
<button class="oe_inline oe_stat_button"
type="object" name="project_open_tms_activity_rep"
icon="fa-tasks" string="TMS Com. Rep" >
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too

:alt: License: AGPL-3

=================================
Timesheet Activity Report Improve
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elicoidal
Actually the BR never mentioned to create a separate module. The improvement must be done in the existing module (simply increment version number...).

@lonelysun
Please arrange refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants