Skip to content

[12.0][BR001549][MIG] project_completion_report: Migration to 12.0#235

Open
Reinhard-sheng wants to merge 8 commits intoElico-Corp:12.0from
Reinhard-sheng:12.0-mig-project_completion_report
Open

[12.0][BR001549][MIG] project_completion_report: Migration to 12.0#235
Reinhard-sheng wants to merge 8 commits intoElico-Corp:12.0from
Reinhard-sheng:12.0-mig-project_completion_report

Conversation

@Reinhard-sheng
Copy link

@Reinhard-sheng Reinhard-sheng commented Mar 25, 2019

WIP

@Reinhard-sheng
Copy link
Author

Reinhard-sheng commented Mar 25, 2019 •
edited
Loading

@elicoidal cc @seb-elico
This report based on module project_project_category which in elico/odoo-addons, should we migrate this module?
And module project_timesheet, project_issue_sheet not exists in V12.

There have V10 type code in PCR 8.0 branch https://github.com/Elico-Corp/odoo-addons/blob/8.0/project_completion_report/report/project_completion_report.py
and V8 type code in PCR 10.0, is it normal ?

@elicoidal
Copy link
Contributor

elicoidal commented Mar 25, 2019

Not normal indeed: might need some cleansing. Do what is necessarry @Reinhard-sheng

@Reinhard-sheng
Copy link
Author

Reinhard-sheng commented Mar 25, 2019

@elicoidal
This report based on module project_project_category which in elico/odoo-addons, should we migrate this module?

@elicoidal
Copy link
Contributor

elicoidal commented Mar 25, 2019

This report based on module project_project_category which in elico/odoo-addons, should we migrate this module?

yes

@Reinhard-sheng
Copy link
Author

Reinhard-sheng commented Mar 26, 2019

@seb-elico @elicoidal
Finished, cause of project.issue MIG to helpdesk, added the odoo_enterprise depends in oca_dependencies.txt

@Reinhard-sheng
Copy link
Author

Reinhard-sheng commented Mar 26, 2019

@seb-elico @elicoidal
Finished, cause of project.issue MIG to helpdesk, added the odoo_enterprise depends in oca_dependencies.txt

@Reinhard-sheng Reinhard-sheng changed the title [MIG] project_completion_report: Migration to 12.0 [BR001549][MIG] project_completion_report: Migration to 12.0 Mar 26, 2019
@Reinhard-sheng Reinhard-sheng changed the title [BR001549][MIG] project_completion_report: Migration to 12.0 [12.0][BR001549][MIG] project_completion_report: Migration to 12.0 Mar 26, 2019
elicoidal
elicoidal reviewed Mar 26, 2019
View reviewed changes
Copy link
Contributor

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except README.

project_completion_report/README.rst

.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
:alt: Try me on Runbot
:target: https://runbot.odoo-community.org/runbot/{repo_id}/{branch}
Copy link
Contributor

@elicoidal elicoidal Mar 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adapt

project_completion_report/README.rst
:alt: Try me on Runbot
:target: https://runbot.odoo-community.org/runbot/{repo_id}/{branch}

.. repo_id is available in https://github.com/OCA/maintainer-tools/blob/master/tools/repos_with_ids.txt
Copy link
Contributor

@elicoidal elicoidal Mar 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments

project_completion_report/README.rst
Credits
=======

Images
Copy link
Contributor

@elicoidal elicoidal Mar 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this section

project_completion_report/README.rst
* Sebastien Maillard <sebastien.maillard@elico-corp.com>
* Reinhard Sheng <reinhard.sheng@elico-corp.com>

Maintainer
Copy link
Contributor

@elicoidal elicoidal Mar 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is old template

project_completion_report/report/project_completion_report.py
"""Project Completion Report"""
tools.drop_view_if_exists(cr, 'project_completion_report')
cr.execute("""
CREATE OR REPLACE VIEW project_completion_report AS (
Copy link
Contributor

@elicoidal elicoidal Mar 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seb-elico review requested here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elicoidal elicoidal elicoidal left review comments

Assignees

No one assigned

Labels

work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Reinhard-sheng @elicoidal