[12.0][BR001549][MIG] project_project_category: Migration to 12.0 by Reinhard-sheng · Pull Request #237 · Elico-Corp/odoo-addons

Reinhard-sheng · 2019-03-25T06:31:36Z

@Elico-Corp/odoo-reviewers

elicoidal · 2019-03-25T06:39:38Z

project_project_category/README.rst

@@ -0,0 +1,60 @@
+.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg


elicoidal · 2019-03-25T06:39:48Z

project_project_category/README.rst

@@ -0,0 +1,60 @@
+.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
+   :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
+   :alt: License: AGPL-3


switch to LGPL too

elicoidal · 2019-03-25T06:39:58Z

project_project_category/README.rst

+
+This module extends the functionality of Project to add a category on the project itself, also support search filter and group by.
+
+Installation


Remove this section

elicoidal · 2019-03-25T06:40:04Z

project_project_category/README.rst

+Bug Tracker
+===========
+
+Bugs are tracked on `GitHub Issues <https://github.com/Elico-Corp/elico_odoo/issues>`_.


odoo-addons

elicoidal · 2019-03-25T06:40:22Z

project_project_category/__manifest__.py

+    'website': 'https://www.elico-corp.com',
+    'support': 'support@elico-corp.com',
+    "author": "Elico corp",
+    "license": "AGPL-3",


project_project_category/data/project_project_category_data.xml

elicoidal · 2019-03-25T06:40:39Z

project_project_category/__manifest__.py

@@ -0,0 +1,23 @@
+# -*- coding: utf-8 -*-


no coding in v12

elicoidal · 2019-03-25T06:40:49Z

project_project_category/data/project_project_category_data.xml

+        </record>
+
+    </data>
+</odoo>


elicoidal · 2019-03-25T06:41:06Z

project_project_category/models/__init__.py

@@ -0,0 +1,5 @@
+# -*- coding: utf-8 -*-
+# © 2016-2017 Elico Corp (https://www.elico-corp.com)


2016-2019 (everywhere)

elicoidal · 2019-03-25T06:41:29Z

project_project_category/views/project_project_view.xml

+                    <field name="project_categ_id"/>
+                </field>
+                <group expand="0" string="Group By">
+                    <filter name ="project_category" string="Project category" domain="[]" context="{'group_by': 'project_categ_id'}"/>


improve readability

Reinhard-sheng · 2019-03-25T06:53:49Z

Updated

elicoidal

almost there

elicoidal · 2019-03-25T07:18:00Z

project_project_category/data/project_project_category_data.xml

+
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <data noupdate="1">


remove data key and merge with odoo

elicoidal · 2019-03-25T07:18:19Z

project_project_category/data/project_project_category_data.xml

@@ -0,0 +1,25 @@
+<!-- -*- coding: utf-8 -*- -->


no coding in XML

Reinhard-sheng · 2019-03-25T07:22:21Z

Updated again.

elicoidal

LGTM. waiting for Travis

elicoidal · 2019-03-25T07:30:47Z

Please check travis

JoJoJoJoJoJoJo

Small details.

JoJoJoJoJoJoJo · 2019-03-25T08:24:30Z

project_project_category/models/project_project_category.py

+class ProjectProjectCategory(models.Model):
+    _name = 'project.project.category'
+
+    name = fields.Char('Name', required=True, translate=True, select=True)


Suggested change

name = fields.Char('Name', required=True, translate=True, select=True)

name = fields.Char('Name', required=True, translate=True, index=True)

select is deprecated.

JoJoJoJoJoJoJo · 2019-03-25T08:28:14Z

project_project_category/models/__init__.py

@@ -0,0 +1,4 @@
+# © 2016-2019 Elico Corp (https://www.elico-corp.com)


License not needed in __init__.py

JoJoJoJoJoJoJo · 2019-03-25T08:29:04Z

project_project_category/__init__.py

@@ -0,0 +1,4 @@
+# © 2016-2019 Elico Corp (https://www.elico-corp.com)
+# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html).


No license here.

JoJoJoJoJoJoJo · 2019-03-25T08:30:32Z

project_project_category/models/project_project_category.py

+# © 2016-2019 Elico Corp (https://www.elico-corp.com)
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+
+from openerp import fields, models


Suggested change

from openerp import fields, models

from odoo import fields, models

JoJoJoJoJoJoJo

LGTM

elicoidal · 2019-03-27T05:19:25Z

project_project_category/models/project_project_category.py

+class ProjectProjectCategory(models.Model):
+    _name = 'project.project.category'
+
+    name = fields.Char('Name', required=True, translate=True, index=True)


no need the strings

elicoidal · 2019-03-27T05:20:04Z

Travis is failing

[MIG] project_project_category: Migration to 12.0

532e12d

elicoidal added the needs review label Mar 25, 2019

elicoidal requested changes Mar 25, 2019

View reviewed changes

Reinhard-sheng added 2 commits March 25, 2019 14:52

[FIX] imp code

b0c0a46

[FIX] imp readme file

5b11c5a

elicoidal reviewed Mar 25, 2019

View reviewed changes

[FIX] imp copyright and remove data tag

afc9389

elicoidal approved these changes Mar 25, 2019

View reviewed changes

[FIX] move <?xml?> to the top

04f1bb4

JoJoJoJoJoJoJo reviewed Mar 25, 2019

View reviewed changes

[IMP] imp code

7f01bec

Reinhard-sheng changed the title ~~[MIG] project_project_category: Migration to 12.0~~ [12.0][BR001549][MIG] project_project_category: Migration to 12.0 Mar 26, 2019

Reinhard-sheng added 2 commits March 26, 2019 14:23

[FIX] fix Travis

343a81a

[FIX] copyright

ae9f2d4

JoJoJoJoJoJoJo approved these changes Mar 27, 2019

View reviewed changes

elicoidal approved these changes Mar 27, 2019

View reviewed changes

		@@ -0,0 +1,60 @@
		.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg


		This module extends the functionality of Project to add a category on the project itself, also support search filter and group by.

		Installation

		@@ -0,0 +1,5 @@
		# -- coding: utf-8 --
		# © 2016-2017 Elico Corp (https://www.elico-corp.com)

	name = fields.Char('Name', required=True, translate=True, select=True)
	name = fields.Char('Name', required=True, translate=True, index=True)

		@@ -0,0 +1,4 @@
		# © 2016-2019 Elico Corp (https://www.elico-corp.com)

		@@ -0,0 +1,4 @@
		# © 2016-2019 Elico Corp (https://www.elico-corp.com)
		# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html).

	from openerp import fields, models
	from odoo import fields, models

Conversation

Reinhard-sheng commented Mar 25, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reinhard-sheng commented Mar 25, 2019

Uh oh!

elicoidal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reinhard-sheng commented Mar 25, 2019

Uh oh!

elicoidal left a comment

Choose a reason for hiding this comment

Uh oh!

elicoidal commented Mar 25, 2019

Uh oh!

JoJoJoJoJoJoJo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JoJoJoJoJoJoJo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elicoidal commented Mar 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants