-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary dicom web client #174
base: master
Are you sure you want to change the base?
Conversation
…up not available on github
nice, this works for me with Orthanc I wonder why you are doing this JSON array parsing. I did not run into a problem with serde_json with array responses. you should also check it with DCM4CHEE, a popular open source PACS Then upload some dicom files with e.g. DCMTK: You will see that DCM4CHEE does not by default respond with the content-length in the multipart body on requesting a file with WADO. I think this is in violation of the standard here, but would still need a workaround since DCM4CHEE is so popular. |
I was doing this to achieve a streaming API on json reading, to save memory and latency, but this is certainly a premature optimisation.
Thanks for the pointer, I will hopefully check this when thinks settle down a bit at Qynapse. In the mean time, feel free to takeover this POC ! |
This is just a POC for now. I tested it with Orthanc only
This PR was based on #173 so the revelant commits are also included.
This is rough and dirty, as I'm neither a dicom or rust expert ...
Regards