Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly return the first element of the array #600

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Correctly return the first element of the array #600

merged 1 commit into from
Nov 13, 2024

Conversation

dougyau
Copy link
Contributor

@dougyau dougyau commented Nov 12, 2024 •
edited
Loading

The fallback code of rescale and voi lut functions return an empty slice instead of the expected 1 element slice.

@Enet4 Enet4 added bug This is a bug A-lib Area: library C-pixeldata Crate: dicom-pixeldata labels Nov 13, 2024
Enet4
Enet4 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch, that was clearly off. 👍

@Enet4 Enet4 merged commit 463d1ae into Enet4:master Nov 13, 2024
5 checks passed
@dougyau dougyau deleted the voi-lut-panic branch November 13, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enet4 Enet4 Enet4 approved these changes

Assignees
No one assigned
Labels
A-lib Area: library bug This is a bug C-pixeldata Crate: dicom-pixeldata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougyau @Enet4