Skip to content

Print filenames of illegal schematic files. Fixes #2966#2976

Merged
me4502 merged 3 commits into
version/7.4.xfrom
chore/print-illegal-schematic-filenames
Jun 28, 2026
Merged

Print filenames of illegal schematic files. Fixes #2966#2976
me4502 merged 3 commits into
version/7.4.xfrom
chore/print-illegal-schematic-filenames

Conversation

@me4502

@me4502 me4502 commented Jun 25, 2026

Copy link
Copy Markdown
Member

This PR prints out the filenames of the illegal schematic files, fixing #2966.

Also additionally hides the stacktrace outside of debug logs, making this seem less like a problem with the plugin to the average user.

@me4502 me4502 requested a review from a team as a code owner June 25, 2026 11:06
@wizjany

wizjany commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Probably more clear to the user if the log says "Invalid file name" instead of "Illegal file".

@me4502

me4502 commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

Probably more clear to the user if the log says "Invalid file name" instead of "Illegal file".

Fair, have changed

@me4502 me4502 enabled auto-merge June 25, 2026 11:49
@me4502 me4502 added this pull request to the merge queue Jun 28, 2026
Merged via the queue into version/7.4.x with commit 079a34f Jun 28, 2026
3 checks passed
@me4502 me4502 deleted the chore/print-illegal-schematic-filenames branch June 28, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants