Skip to content

Conversation

@aparton
Copy link
Contributor

@aparton aparton commented Jul 6, 2020

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0006%) to 83.032% when pulling 7823c71 on aparton:bugfix/shifting101 into 0e41a0d on Ensembl:release/101.

@sarahhunt sarahhunt self-assigned this Jul 13, 2020
@sarahhunt
Copy link
Member

I looks like there is something odd happening in _overlaps_start_codon and the variant should exit this routine earlier.
cdna_start_unshifted and cdna_end_unshifted are null, as the variant doesn't overlap the cDNA. The shifting offset is added to this, to give a cdna_start & cdna_end of 500, which overlaps the start codon. This addition would only be correct if we knew the the variant was at the base before the cDNA, which we don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants