Skip to content

Clarify bdr.run_on_all_nodes() behavior #6947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Clarify bdr.run_on_all_nodes() behavior #6947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions product_docs/docs/pgd/5.8/ddl/ddl-managing-with-pgd-replication.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ $ddl$);
```

We recommend using the [`bdr.run_on_all_nodes()`](/pgd/5.8/reference/functions#bdrrun_on_all_nodes) technique with `CREATE
INDEX CONCURRENTLY`, noting that DDL replication must be disabled for the whole
session because `CREATE INDEX CONCURRENTLY` is a multi-transaction command.
INDEX CONCURRENTLY`.
Avoid `CREATE INDEX` on production systems
since it prevents writes while it executes.
`REINDEX` is replicated in versions 3.6 and earlier but not with PGD 3.7 or later.
Expand Down
3 changes: 1 addition & 2 deletions product_docs/docs/pgd/6/reference/ddl/ddl-managing-with-pgd-replication.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ $ddl$);
```

We recommend using the [`bdr.run_on_all_nodes()`](/pgd/latest/reference/tables-views-functions/functions#bdrrun_on_all_nodes) technique with `CREATE
INDEX CONCURRENTLY`, noting that DDL replication must be disabled for the whole
session because `CREATE INDEX CONCURRENTLY` is a multi-transaction command.
INDEX CONCURRENTLY`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't anymore in 6 because CIC is anyway executed concurrently now via replication

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we recommend run on all nodes for DDL at all in 6

Avoid `CREATE INDEX` on production systems
since it prevents writes while it executes.
Avoid using `REINDEX` because of the AccessExclusiveLocks it holds.
Expand Down