Clarify the assumptions about the key path provided #6980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See this Slack discussion https://edb.slack.com/archives/CDTA6PCJV/p1758928515169919 In some cases the path provided is absolute, sometimes it's relative. If the command runs, as assumed, in the Postgres data directory, this makes no difference. However, if the current directory changes at run time, the wrap/unwrap commands will have trouble locating the key file if the relative path were used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this Slack discussion https://edb.slack.com/archives/CDTA6PCJV/p1758928515169919
In some cases the path provided is absolute, sometimes it's relative. If the command runs, as assumed, in the Postgres data directory, this makes no difference. However, if the current directory changes at run time, the wrap/unwrap commands will have trouble locating the key file if the relative path were used.
What Changed?
Clarified the conditions under which the wrap/unwrap commands are executed, and the assumptions about the
%pvariable substitution.Based on a real customer scenario.