Gate windows-sys dependencies on Windows targets and fix UTF-8 terminal output#45
Open
subhramit wants to merge 3 commits into
Open
Gate windows-sys dependencies on Windows targets and fix UTF-8 terminal output#45subhramit wants to merge 3 commits into
windows-sys dependencies on Windows targets and fix UTF-8 terminal output#45subhramit wants to merge 3 commits into
Conversation
Four crates listed `windows-sys` under `[dependencies]`, causing build failures on non-x86_64 Linux architectures. Move them under `[target.'cfg(target_family = "windows")'.dependencies]`. Fixes EpicGames#43 Signed-off-by: subhramit <subhramit.bb@live.in>
mjansson
approved these changes
Jun 22, 2026
mjansson
left a comment
mjansson
left a comment
Collaborator
There was a problem hiding this comment.
Makes sense to me, looks good
subhramit
changed the title
windows-sys dependency under Windows targetswindows-sys dependencies under Windows targets
`lore history` and other pager-backed commands produced mojibake for non-ASCII characters on Windows because the console codepage defaulted to a legacy encoding. Call `SetConsoleOutputCP(CP_UTF8)` at CLI startup under `#[cfg(target_family = "windows")]` so all output, including pager-spawned subprocesses, uses UTF-8 from the start. Fixes EpicGames#30 Signed-off-by: subhramit <subhramit.bb@live.in>
…s-sys-platform-gate
subhramit
changed the title
windows-sys dependencies under Windows targets
Author
|
Extended scope of the PR due to #77 (comment). |
subhramit
changed the title
windows-sys dependencies on Windows targets and fix UTF-8 terminal output
mjansson
approved these changes
Jul 7, 2026
Collaborator
|
We'll get this merged once the intake and attribution process is in place, ideally early next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of cross-platform build portability.
Fixes #43
Fixes #30
windows-sysunder[dependencies]instead of[target.'cfg(target_family = "windows")'.dependencies], causing build failures on non-x86_64 Linux architectures. This moves them under the right (Windows) targets.lore history. So to fix that, this also adds aSetConsoleOutputCP(CP_UTF8)call at the CLI startup.