fix: raise error when auth login remote URL is missing#84
Open
euxaristia wants to merge 1 commit into
Open
Conversation
Avoid a silent/hanging failure when running 'lore auth login' without a remote URL argument or configured repository remote. Add CLI-side validation and comprehensive unit tests to ensure a clear error is printed to the user. Signed-off-by: euxaristia <euxaristia@users.noreply.github.com>
euxaristia
force-pushed
the
fix-auth-login-silent-failure
branch
from
bde655c to
2772568
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid a silent/hanging failure when running
lore auth loginwithout a remote URL argument or configured repository remote.lore-client/src/cli/commands/auth.rs.lore/src/auth.rsfor non-interactive login paths.