add protobuf-based evaluator - #80
Draft
leoromanovsky wants to merge 10 commits into
Draft
leoromanovsky wants to merge 10 commits into
leoromanovsky wants to merge 10 commits into
Conversation
leoromanovsky
force-pushed
the
lr/pb-client
branch
from
November 7, 2025 03:30
25f06d5 to
da5f550
Compare
- Fix evaluator selection to use experimentalPbRequest parameter instead of initialConfiguration format, ensuring correct evaluator is chosen - Fix convertProtobufVariationTypeToUFC to explicitly handle all enum cases including .variationValueTypeUnspecified and .UNRECOGNIZED variants - Resolves "unimplemented enum kind" error and "stepping into wrong evaluator" issue 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Fixes issue
📜 Design Doc: link if applicable
Motivation and Context
Description
How has this been documented?
How has this been tested?