Fixing access-scope bug in EppoClient. - #82
Open
JThramer wants to merge 3 commits into
Open
Conversation
Fixing issue where it was impossible to manually loadInitialConfiguration, because configurationStore was an internal variable
Author
|
@petzel that's sensible, I don't mind if persistent cache for configurations is handled for me, but the core issue is that the persistent cache is broken when you initialize offline, regardless of what you specify as the The feature looks like it works in the async initializer, but we can't use that due to technical constraints. Does this make sense? Happy to answer any more questions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Fixes issue
📜 Design Doc: link if applicable
Motivation and Context
When initializing offline, it may be desirable to attempt to load a cached configuration from the configuration cache. This is not possible to do manually by the client-developer.
Description
Fixing issue where it was impossible to manually loadInitialConfiguration, because configurationStore was an internal variable.
How has this been documented?
How has this been tested?