bug: scope configuration file per sdk key (#84) - #85
Draft
leoromanovsky wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Fixes issue
📜 Design Doc: link if applicable
Motivation and Context
Fixes #83 - Configuration cache not respecting environment boundaries when switching SDK keys.
Customer Issue:
When customers switch between environments (production, staging, development) by initializing the SDK with different SDK keys, the ConfigurationStore was sharing a single cache file across all environments. This caused configuration from one environment to persist and be loaded in another environment, leading to incorrect feature flag behavior.
Description
ConfigurationStore.swift:
sdkKeyparameterfindCacheFileURL()to generate SDK-key-specific cache filenameseppo-configuration-{abs(sdkKeyHash)}.jsonsdkKeyis nil (uses original filename)clearPersistentCache()to accept optional SDK key parameterEppoClient.swift:
How has this been documented?
How has this been tested?