fix(backend): tighten agent-not-found coverage in dispatch tests (#173) - #207
Merged
devJaja merged 1 commit intoJul 26, 2026
Merged
Conversation
…a-Node#173) - pipeline.test.ts: add e2e test that exercises the agent-not-found branch of makeHttpDispatch (registry returns []) and asserts at least one failed DAG node carries the descriptive "No agent registered for type:<x>" error. Tolerates the upstream_failed cascade from coordinator.failBlockedNodes. - dispatch.test.ts: remove unused mockFetch originalImpl line in the "retries on 429" test.
|
@malaysiaonelove is attempting to deploy a commit to the Jaja's projects Team on Vercel. A member of the Team first needs to authorize it. |
devJaja
self-requested a review
July 26, 2026 12:43
devJaja
approved these changes
Jul 26, 2026
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #173
Summary
Strengthens test coverage for the agent dispatch pipeline that #173 put in place. The original fix replaced the throwing
defaultDispatchwithmakeHttpDispatch+httpDispatch, but was missing a literal acceptance test confirming that the agent-not-found error is descriptive and observable end-to-end.Changes
backend/tests/e2e/pipeline.test.ts: Added a new e2e test,"reports \"No agent registered for type:<x>\" when registry returns no agents", that provesmakeHttpDispatchpropagates a descriptive error to the failed DAG node, observable viaGET /api/tasks/:id. The assertion is intentionally loose (expect(withAgentErr.length).toBeGreaterThan(0)) so it tolerates the coordinator'supstream_failedcascade on dependent nodes, while still failing if the descriptive error message ever regresses to a genericError('dispatch failed').backend/src/coordinator/dispatch.test.ts: Removed a deadoriginalImpldeclaration in the "retries on 429 rate-limit response" test.Testing
backend/src/coordinator/dispatch.test.ts— 13/13 unit tests passbackend/tests/e2e/pipeline.test.ts— 11/11 e2e tests pass (was 10/10; +1 new)npx tsc --noEmit— cleanRelated Issue
Closes #173
Checklist