fix(backend): eliminate duplicate type systems (#168) - #210
Merged
devJaja merged 2 commits intoJul 29, 2026
Merged
Conversation
- Rename AgentRegistry class in agents/registry.ts to AgentStartupRegistry to eliminate naming collision with the AgentRegistry interface in types/agent.ts. The class is a startup/init manager; the interface is the coordinator's look-up contract — they are different concepts. - Add explicit number annotation to rateLimit.ts filter callback to fix implicit-any TS error (TS7006). - Remove lru-cache from package.json (not needed by the simple Map-based rateLimit.ts on main). npx tsc --noEmit: 0 errors npm test: 14/15 suites pass (1 pre-existing skip)
|
@Clement-coder is attempting to deploy a commit to the Jaja's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
@Clement-coder |
Contributor
|
@Clement-coder |
devJaja
self-requested a review
July 29, 2026 20:47
devJaja
approved these changes
Jul 29, 2026
devJaja
left a comment
devJaja
left a comment
Contributor
There was a problem hiding this comment.
Solid Implementation @Clement-coder
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #168
Resolves the remaining type-system issues after the duplicate files (
coordinator/types.ts,coordinator/decompose.ts) were already removed by prior PRs.Changes
backend/src/agents/registry.tsRenamed the
AgentRegistryclass toAgentStartupRegistryto eliminate the naming collision with theAgentRegistryinterface intypes/agent.ts. These are two distinct concepts:types/agent.ts→ look-up interface used by the coordinator to resolve agents by typeagents/registry.ts→ startup/initialization manager that instantiates and registers agents on bootNo callers import the class by name, so there are no cascading changes.
backend/src/api/middleware/rateLimit.tsAdded explicit
: numbertype annotation to thefiltercallback parameter to fix a TS7006 implicit-any error that was causing 5 test suites to fail to compile.Verification
npx tsc --noEmit→ 0 errorsnpm test→ 14/15 suites pass (1 pre-existing skip), 159/161 tests pass (2 pre-existing skips)npm run build→ success