Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several Changes (options, refactoring, and bugfixes) #3

Merged
merged 4 commits into from
Jun 3, 2018

Conversation

Erotemic
Copy link
Owner

Change 1: Moves formatting code into its own module.

Change 2: Adds an argument options to static_init. Currently there are 3 options available:

Change 3: Improved algo for selecting where to insert auto generated text when AUTOGEN_INIT tags are not give. This changes uses the xdoctest PS1 parsing logic to determine if a line is "top-level". This prevents clobbering of some multiline statements. Current solution should be refactored and improved, but its much better than the old algo.

Change 3: Removed attr kwarg from static_init, use options['with_attrs'] instead. This is a breaking change.

@codecov-io
Copy link

codecov-io commented May 27, 2018

Codecov Report

Merging #3 into master will increase coverage by 1.19%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage    82.5%   83.69%   +1.19%     
==========================================
  Files           3        4       +1     
  Lines         360      411      +51     
  Branches       67       81      +14     
==========================================
+ Hits          297      344      +47     
  Misses         46       46              
- Partials       17       21       +4
Impacted Files Coverage Δ
mkinit/dynamic_mkinit.py 66.4% <ø> (ø) ⬆️
mkinit/static_mkinit.py 87.14% <100%> (-0.57%) ⬇️
mkinit/formatting.py 90.29% <90.29%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865667a...152c60d. Read the comment docs.

@vltr
Copy link

vltr commented May 27, 2018

WooHoo 🍻

@Erotemic Erotemic merged commit 3cae98a into master Jun 3, 2018
@Erotemic Erotemic deleted the dev/refactor_formatting branch June 3, 2018 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants