Interactive Legend: Predominance expression where clause #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rslibed
requested review from
kellyhutchins,
Csmith246,
bcree11 and
JoeRodriguez-136
bcree11
reviewed
Sep 19, 2024
| @@ -212,8 +212,7 @@ export function handlePredominanceExpression(elementInfo: any, featureLayerView: | |||
| if (elementInfo.value === field) { | |||
| return; | |||
| } | |||
| const sqlQuery = `(${elementInfo.value} > ${field} OR (${field} IS NULL AND ${elementInfo.value} <> 0 AND ${elementInfo.value} IS NOT NULL))`; | |||
|
|
|||
| const sqlQuery = `(${elementInfo.value} > ${field} OR (${field} IS NULL AND ${elementInfo.value} IS NOT NULL AND (${elementInfo.value} > 0 AND ${elementInfo.value} < 0)))`; | |||
There was a problem hiding this comment.
How would this work? (${elementInfo.value} > 0 AND ${elementInfo.value} < 0)
There was a problem hiding this comment.
Oops you're right, I updated AND to OR. ${elementInfo.value} <> 0 wasn't working properly so I was trying to write an alternative to that.
Csmith246
approved these changes
Sep 19, 2024
instant-apps-componentsThe following PR has been closed and merged. - link to PR If you want to publish, your Repo version should be updated and differ from the current version on NPM To publish instant-apps-components to NPMIf you would like to follow this PR up with a publish, please proceed to the actions tab and manually run the publish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.