Conversation
|
I also added a debug in the config.yml to output to the minecraft console. I have plans to include MySQL and SQLite database types instead of serial. |
EtienneDx
left a comment
There was a problem hiding this comment.
Thanks a lot for picking this up. Feel free to add a redirect in the readme to your own repo, or to keep sharing here. I can also add you directly to the repo so you can create releases here. I'll probably stay available for reviews but it's unlikely that I'll dive back in.
There was a problem hiding this comment.
Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (5)
- pom.xml: Language not supported
- src/me/EtienneDx/RealEstate/ClaimPermissionListener.java: Evaluated as low risk
- src/me/EtienneDx/RealEstate/Config.java: Evaluated as low risk
- src/me/EtienneDx/RealEstate/RealEstate.java: Evaluated as low risk
- src/me/EtienneDx/RealEstate/Transactions/ClaimRent.java: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/me/EtienneDx/RealEstate/Transactions/ClaimSell.java:42
- The method getSide(Side.FRONT) may not be supported in all versions of the API. Ensure compatibility or provide a fallback.
s.getSide(Side.FRONT).setLine(0, Messages.getMessage(RealEstate.instance.config.cfgSignsHeader, false));
|
No worries. I'll clean up the code. I wanted to at least offer a small portion to give back to the plugin I used many years ago. My minecraft server is getting larger and thought I would attempt an update. I mainly code PHP, and C#. My first time in Java. lol. |
I would never steal your code. I don't think it'd be fair to do that. If you want to add me to your repo that'd be great, or I can do PRs. Either way works for me. :) |
|
I've added you to the repo, feel free to go the extra step and create a release with the jar and changelog! |
Please see change log.
|
I think you'll like the improvements. Have a look at the new commit. |
Please see changelog
EtienneDx
left a comment
There was a problem hiding this comment.
Love the changes, I left a couple comments. One thing, it'd be great to run a formatter on the codebase to be consistent on spaces/tabs (or at least on the modified files).
|
Can you add me on Discord? I have a couple of questions: |
Include a static file to reduce plugin load time.
Moved Language resource files to better manage community translations.
Per request
Introduces Javadoc, WorldGuard, and Towny
Included bStats Updated language files
EtienneDx
left a comment
There was a problem hiding this comment.
Looks good to merge. I think maybe we could improve a little the code on the transactionStore by having an ITransactionStore and a TransactionStoreFile, TransactionStoreMysql etc but that's not important. Let's merge this now beofer adding new commits since it's becoming a large chunk to review :)
Removed deprecated functions.
Updated API to 1.21.4