Add About us page #1214
Merged
Add About us page #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Preview available
|
…site into ep2025-about-us-2
for more information, see https://pre-commit.ci
nikoshell
reviewed
May 11, 2025
There was a problem hiding this comment.
I suggest to use md in some case can be mdx, if it must be mdx pls use / create astro components instead of huge html block. If html source is bigger then md, we should create astro page.
Other way it will be hard to maintain.
In this case with this content md file will be good.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This reverts commit f8122d6.
for more information, see https://pre-commit.ci
This reverts commit 5a60849.
This reverts commit 3bbf150.
This reverts commit f8122d6.
This reverts commit 95a6d0f.
hypha
reviewed
May 12, 2025
hypha
reviewed
May 12, 2025
|
Hey @hypha thanks a lot for the feedback! The PR is still a draft, I just copied names from the onboarding spreadsheet, so I'm aware that I was missing some people. I've addressed all your remarks and hopefully, I didn't miss anyone 🙂 |
for more information, see https://pre-commit.ci
thepetk
requested changes
May 13, 2025
Co-authored-by: Theofanis Petkos <[email protected]>
thepetk
reviewed
May 13, 2025
Co-authored-by: Theofanis Petkos <[email protected]>
for more information, see https://pre-commit.ci
egeakman
reviewed
May 13, 2025
Co-authored-by: Ege Akman <[email protected]>
Co-authored-by: Ege Akman <[email protected]>
for more information, see https://pre-commit.ci
thepetk
approved these changes
May 13, 2025
Co-authored-by: hypha <[email protected]>
for more information, see https://pre-commit.ci
|
alright, thank you everyone for your feedback, I've addressed all the notes - can I merge the PR? |
thepetk
reviewed
May 14, 2025
this was my bad! Co-authored-by: Theofanis Petkos <[email protected]>
Co-authored-by: Theofanis Petkos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.