Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to mpl-pan-zoom #17

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Switch to mpl-pan-zoom #17

merged 1 commit into from
Jul 5, 2023
+4 −22

Conversation

JamesWrigley
Copy link
Member

This is the sucessor to mpl-interactions. Fixes #10.

@JamesWrigley JamesWrigley self-assigned this Jul 4, 2023
@JamesWrigley
Switch to mpl-pan-zoom
e7a2b81 
This is the sucessor to mpl-interactions.
tmichela
tmichela approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@tmichela tmichela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested, assuming you did, this LGTM

@takluyver
Copy link
Member

LGTM too

@JamesWrigley
Copy link
Member Author

I haven't tested, assuming you did, this LGTM

Yep, I did 👍 (also with Thomas K in a peer review)

@JamesWrigley JamesWrigley merged commit dc6f697 into master Jul 5, 2023
@JamesWrigley JamesWrigley deleted the mpl-pan branch July 5, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmichela tmichela tmichela approved these changes

@takluyver takluyver Awaiting requested review from takluyver

Assignees

@JamesWrigley JamesWrigley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to mpl-pan-zoom to get widgetlocking behavior
3 participants
@JamesWrigley @takluyver @tmichela