-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up the API for release #235
Conversation
I made some more tests and added a |
Should we treat empty strings as being 'available' for |
Added docs in 2e3c4be. |
You mean, if a key is only in the database and its value there is Line 670 in bb7ad08
You probably can for comments, though. I'd say it's probably more friendly to say you can always look up comment, even if it's empty. But I don't feel strongly about that. You could argue that treating empty comments as absent from that run is in keeping with what we do for other missing variables. |
I moved the API to the toplevel module in af7bbc9. I also tried out the include-missing-variables API but didn't really like it, it's annoying to have an extra step to check which variables are actually present 🤷 |
If there's no objections, I'd like to merge and deploy this tomorrow. |
Co-authored-by: Thomas Kluyver <[email protected]>
Leaving this as a draft for now because it's still missing a lot of edge cases, notably around user-editable variables.
Example:
Fixes #33.