Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix variable name validation #384

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

tmichela
Copy link
Member

@tmichela tmichela commented Feb 3, 2025

fixes #383

@tmichela tmichela requested a review from CammilleCC February 3, 2025 13:43
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.93%. Comparing base (5113981) to head (302f299).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #384   +/-   ##
=======================================
  Coverage   75.93%   75.93%           
=======================================
  Files          33       33           
  Lines        5493     5493           
=======================================
  Hits         4171     4171           
  Misses       1322     1322           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@CammilleCC CammilleCC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant fix! LGTM

@tmichela tmichela merged commit ab692ff into master Feb 3, 2025
6 checks passed
@tmichela tmichela deleted the fix/variableNameValidation branch February 3, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variables with single character are not processed
2 participants