Refactor the listener to allow for being centralized #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #394 +/- ##
==========================================
+ Coverage 75.70% 76.87% +1.16%
==========================================
Files 35 35
Lines 5932 6123 +191
==========================================
+ Hits 4491 4707 +216
+ Misses 1441 1416 -25 ☔ View full report in Codecov by Sentry. |
This isn't particularly clean, but the delay is only 0.1s so it should be acceptable.
Two changes: - Access the environment variable override in the function so we can set it at runtime. - Take in an integer proposal number and apply formatting internally.
This allows them to specify which DAMNIT environment to use for processing runs, independently of what environment the processing is triggered from.
JamesWrigley
force-pushed
the
listener
branch
from
5d63d61 to
9983abc
Compare
Important changes: - The listener now supports triggering jobs for either all proposals or a single one. - In addition to the 'official' databases under `usr/Shared/amore`, it's possible to add unofficial databases at any location. - The GUI now only initializes the database and assumes a listener is already running.
For some reason it was still running afterwards, which would cause segfaults.
Amusingly, this will otherwise semi-randomly cause segfaults when... something... gets garbage collected before it should be.
JamesWrigley
force-pushed
the
listener
branch
from
9983abc to
b5a7ba9
Compare
|
I extended the tests and added some docs here: https://damnit--394.org.readthedocs.build/en/394/internals/#the-listener |
|
Hmph, just realized that the limit on the number of concurrent jobs should be per-proposal rather than global. Will fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important changes:
usr/Shared/amore, it'spossible to add unofficial databases at any location.
running.
I've tried to keep the commits atomic so I would suggest reviewing them one-by-one. @RobertRosca, @CammilleCC, I believe this is ready to be tested.