Fix Dockerfile that was missing LICENSE file #405
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
build
stage of the Dockerfile was trying to create just enough of the source folder to install the dependencies. This broke on a new version of Flit because the LICENSE file wasn't included. But I don't think there's any problem with just copying the whole git repo folder in, like the app stage does later. So this simplfiies it.@RobertRosca what do we gain by installing all the dependencies in the build stage and then installing DAMNIT itself separately in the app stage? Could we just install it in the build stage and then copy it across as part of
/app
?