Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile that was missing LICENSE file #405

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

takluyver
Copy link
Member

The build stage of the Dockerfile was trying to create just enough of the source folder to install the dependencies. This broke on a new version of Flit because the LICENSE file wasn't included. But I don't think there's any problem with just copying the whole git repo folder in, like the app stage does later. So this simplfiies it.

@RobertRosca what do we gain by installing all the dependencies in the build stage and then installing DAMNIT itself separately in the app stage? Could we just install it in the build stage and then copy it across as part of /app?

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.24%. Comparing base (17e0755) to head (151c01f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #405   +/-   ##
=======================================
  Coverage   76.24%   76.24%           
=======================================
  Files          35       35           
  Lines        6063     6063           
=======================================
  Hits         4623     4623           
  Misses       1440     1440           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmichela
Copy link
Member

Thanks! LGTM
Maybe you can also revert 21baa24 where I lower the flit version.

@takluyver takluyver force-pushed the fix/docker-install-normal branch from 07d98bb to 151c01f Compare February 26, 2025 08:32
@takluyver takluyver merged commit 6b8cfcd into master Feb 26, 2025
6 checks passed
@takluyver takluyver deleted the fix/docker-install-normal branch February 26, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants