Open
Conversation
- obviously this would be easier with generics, right now there's an issue where we need to have `UserDefinedEvent|Event` on the `handle` argument type declaration which feels unnecessary since `Event` is abstract..
- also corrected casing to be consistent with static method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this may be reasonable, going to think on it for a bit and consult with some friends in regard to a few things i'm unhappy with, specifically:
UserDefinedEvent|Eventonhandlemethod of aHandlerin any case this is an improvement over the previous code which was showing its age after almost 10 years.