Skip to content

⚡️ add import aliasing#20

Open
shaunchander wants to merge 8 commits intoEventHorizonLab:devfrom
shaunchander:add-import-aliasing
Open

⚡️ add import aliasing#20
shaunchander wants to merge 8 commits intoEventHorizonLab:devfrom
shaunchander:add-import-aliasing

Conversation

@shaunchander
Copy link

@shaunchander shaunchander commented Feb 18, 2023

  • adds import aliasing using @ convention
  • Removes .js from import statements

Copy link
Collaborator

@LMLiam LMLiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken .json in package.json

@LMLiam
Copy link
Collaborator

LMLiam commented Feb 18, 2023

Also seen as you're using the @ convention - would it not be useful to also do it for enums, objects etc.?

@shaunchander shaunchander changed the base branch from master to dev February 18, 2023 16:31
@LMLiam
Copy link
Collaborator

LMLiam commented Feb 18, 2023

There's still some files where .js hasn't been added back in and broken .json in package.json still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants