fix: replace bare except, enforce ISO 8601 timestamp, remove duplicate docstring#110
Open
Jah-yee wants to merge 1 commit intoEverMind-AI:mainfrom
Open
fix: replace bare except, enforce ISO 8601 timestamp, remove duplicate docstring#110Jah-yee wants to merge 1 commit intoEverMind-AI:mainfrom
Jah-yee wants to merge 1 commit intoEverMind-AI:mainfrom
Conversation
…e docstring - Replace bare 'except:' with 'except Exception:' in: - src/biz_layer/mem_db_operations.py (line 146) - src/infra_layer/adapters/out/search/repository/episodic_memory_milvus_repository.py (line 127) - Enforce ISO 8601 timestamp format in episodic memory prompts: - Add strict format requirements: YYYY-MM-DDTHH:MM:SSZ or YYYY-MM-DDTHH:MM:SS+HH:MM - Update examples to use ISO 8601 format - Prevents inconsistent timestamp formats (Chinese chars, weekdays, AM/PM, UTC) - Remove duplicate 'rrf' entry in demo/utils/simple_memory_manager.py docstring Fixes EverMind-AI#107, EverMind-AI#97, EverMind-AI#108 (related to EverMind-AI#48)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
This PR addresses multiple issues to improve code quality and consistency:
Changes
1. Replace bare except with except Exception (Fixes #107)
src/biz_layer/mem_db_operations.py(line 146)src/infra_layer/adapters/out/search/repository/episodic_memory_milvus_repository.py(line 127)Reason: Bare
except:catchesBaseExceptionincludingKeyboardInterruptandSystemExit. Usingexcept Exception:preserves fallback behavior while allowing system exceptions to propagate.2. Enforce ISO 8601 timestamp format (Fixes #108, related to #48)
src/memory_layer/prompts/en/episode_mem_prompts.pyto require strict ISO 8601 format:Reason: Previous timestamps had inconsistent formats causing parsing issues.
3. Remove duplicate rrf entry in docstring (Fixes #97)
demo/utils/simple_memory_manager.py- removed duplicate rrf mode entryLocal Testing
All modified files pass Python syntax validation:
Warmly,
Spark (on behalf of Spark Lab)
感谢你们的奉献，希望能提供帮助。如果我解决得有问题或有待商妥的地方，请在下面留言，我会来处理。