refactor: rewrite CustomScpTermination - #624
Closed
XingYeNotFish wants to merge 4 commits into
Closed
Conversation
Refine and match corresponding DamageHandler
louis1706
reviewed
Aug 12, 2025
| /// <param name="scpName">SCP Name. Note that for larger numbers, C.A.S.S.I.E will pronounce the place (eg. "457" -> "four hundred fifty seven"). Spaces can be used to prevent this behavior.</param> | ||
| /// <param name="scpNumber">SCP Number. Note that for larger numbers, C.A.S.S.I.E will pronounce the place (eg. "457" -> "four hundred fifty seven"). Spaces can be used to prevent this behavior.</param> | ||
| /// <param name="info">Hit Information.</param> | ||
| public static void CustomScpTermination(string scpName, CustomHandlerBase info) |
ITeMbI4
reviewed
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refine and match corresponding DamageHandler
Description
Describe the changes
Refactored CustomScpTermination to align with the new CustomHandler type and DamageType enumeration, removed overly-restrictive CustomHandlerBase type checks, filled in all missing kill scenarios.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
(Impact is zero if the entire codebase already uses CustomHandler.)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other