Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove EXV_SEPARATOR #3213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove EXV_SEPARATOR #3213

wants to merge 1 commit into from

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Mar 14, 2025

No need with std::filesystem

@neheb
remove EXV_SEPARATOR
3b865bc 
No need with std::filesystem

Signed-off-by: Rosen Penev <[email protected]>
@neheb neheb requested a review from kmilos March 14, 2025 20:20
@kmilos
Copy link
Collaborator

kmilos commented Mar 17, 2025

I really don't know what to think about std::filesystem any more, and whether it's a good idea to proliferate its use:

https://stackoverflow.com/questions/57603013/how-to-safely-convert-const-char-to-const-char8-t-in-c20

@neheb
Copy link
Collaborator Author

neheb commented Mar 17, 2025

Not sure how that applies here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmilos kmilos Awaiting requested review from kmilos

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neheb @kmilos