use actual array instead of C string #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neheb
force-pushed
the
3
branch
2 times, most recently
from
1933024 to
809a0d5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3214 +/- ##
==========================================
- Coverage 63.93% 63.91% -0.02%
==========================================
Files 104 104
Lines 21755 21752 -3
Branches 10636 10636
==========================================
- Hits 13908 13903 -5
- Misses 5639 5641 +2
Partials 2208 2208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
neheb
force-pushed
the
3
branch
3 times, most recently
from
e3403fd to
55778b8
Compare
src/jpgimage.cpp
Outdated
Comment on lines
78
to
84
| constexpr std::array<byte, 6> exifId_{ | ||
| 0x45, 0x78, 0x69, 0x66, 0x00, 0x00, | ||
| }; //!< Exif identifier | ||
| constexpr std::array<byte, 29> xmpId_{ | ||
| 0x68, 0x74, 0x74, 0x70, 0x3A, 0x2F, 0x2F, 0x6E, 0x73, 0x2E, 0x61, 0x64, 0x6F, 0x62, 0x65, | ||
| 0x2E, 0x63, 0x6F, 0x6D, 0x2F, 0x78, 0x61, 0x70, 0x2F, 0x31, 0x2E, 0x30, 0x2F, 0x00, | ||
| }; //!< XMP packet identifier |
There was a problem hiding this comment.
I don't like this change. These were readable strings before, but now they look like binary data.
There was a problem hiding this comment.
How about switching to '' notation?
C strings in C++ have an extra member for NULL termination. replacing copy_n with copy like this will allow eventual conversion to std::ranges. Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
kevinbackhouse
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C strings in C++ have an extra member for NULL termination. replacing copy_n with copy like this will allow eventual conversion to std::ranges.
Missed changes from last PR.