[GR Phase 2] Step 5 Director information screen (without API calls) - implementation #51648

burczu · 2024-10-29T12:19:33Z

Details

This PR contains implementation of step 5 (Director information screen) - GR phase 2.

Design doc section: https://docs.google.com/document/d/1Y4P7G9h0Easjcea7wyk52gKrNB9o1yTjpmJFYkrHDW4/edit?tab=t.0#bookmark=id.damtu6jbu35v

Fixed Issues

$ #50901
PROPOSAL: n/a

Tests

Log in to the app
Open Workspace with Workflows feature enabled
Tap on "Connect bank account" inside the "Make or track payments" section
Go to the 5th step of the flow
Test the flow

Verify that no errors appear in the JS console

Offline tests

Same as above.

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-13.at.12.36.26.mov

Android: mWeb Chrome

Screen.Recording.2024-11-13.at.12.40.06.mov

iOS: Native

Screen.Recording.2024-11-13.at.12.20.07.mov

iOS: mWeb Safari

Screen.Recording.2024-11-13.at.12.23.15.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-13.at.12.13.01.mov

MacOS: Desktop

Screen.Recording.2024-11-13.at.12.18.37.mov

…d help links

melvin-bot · 2024-11-06T12:02:43Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dannymcclain · 2024-11-06T14:08:55Z

I wasn't super involved with this, so we should probably wait for the other members of @Expensify/design to weigh in here, but generally this looks pretty good. A few questions/comments:

What size are the radio check circles? They look a little small to me? In Figma they're 28x28px
Seems like there's some weirdness going on with the attachment selector on iOS—any idea what's going on there?
The attachment preview looks pretty borked when the file name is really long (icon gets pushed out of the container, the file name doesn't truncate, etc)
- Is that something we need to handle here or is that being dealt with elsewhere?
I think all the single input screens (legal name, job title) need to autofocus the input when you get to them (for the first time or any subsequent time)—that's how we typically handle inputs like that

shawnborton · 2024-11-06T14:50:54Z

Feeling good! I have the same feedback as Danny above regarding the checkbox size.

Then for this screen, the blue link looks like it's not left-aligned the same way the others are:

Then for this screen, it feels like the input could be a bit closer to the headline?

dubielzyk-expensify · 2024-11-07T01:15:18Z

Then for this screen, it feels like the input could be a bit closer to the headline?

This goes for the legal name screen too

hungvu193 · 2024-11-08T09:09:34Z

@burczu would you mind addressing these advices from design team above? ty

…reen

burczu · 2024-11-08T10:06:11Z

@hungvu193 yes, on it!

src/pages/ReimbursementAccount/NonUSD/SignerInfo/EnterEmail.tsx

src/pages/ReimbursementAccount/NonUSD/SignerInfo/DirectorCheck.tsx

src/pages/ReimbursementAccount/NonUSD/SignerInfo/EnterEmail.tsx

hungvu193 · 2024-11-11T03:41:13Z

Error message is too close to the Upload file component.

…reen

burczu · 2024-11-13T09:13:08Z

Infinite loop when pressing back between LegalName and Email page.

fixed

burczu · 2024-11-13T09:50:44Z

On Native platform, the attachment icon is out of the border.

fixed

hungvu193 · 2024-11-13T10:08:12Z

Nice. I'll verify it shortly

hungvu193 · 2024-11-13T10:08:46Z

@burczu Can you also update the screenshots/videos so Design team can review the UI?

burczu · 2024-11-13T10:24:38Z

@burczu Can you also update the screenshots/videos so Design team can review the UI?

I will, but still I have few things here to address, so I'll do it once its all done. I think you can wait till then with verification - I'll post a separate comment that's it ready to re-review.

hungvu193 · 2024-11-13T10:25:38Z

@burczu Can you also update the screenshots/videos so Design team can review the UI?

I will, but still I have few things here to address, so I'll do it once its all done. I think you can wait till then with verification - I'll post a separate comment that's it ready to re-review.

Cool. Let me know when it's ready for another review. Ty

burczu · 2024-11-13T11:09:18Z

@dannymcclain Answering your comments:

I wasn't super involved with this, so we should probably wait for the other members of @Expensify/design to weigh in here, but generally this looks pretty good. A few questions/comments:

What size are the radio check circles? They look a little small to me? In Figma they're 28x28px

Good point - fixed.

Seems like there's some weirdness going on with the attachment selector on iOS—any idea what's going on there?

I think this is because of the simulator, I believe this will work correctly on real device.

The attachment preview looks pretty borked when the file name is really long (icon gets pushed out of the container, the file name doesn't truncate, etc)

Is that something we need to handle here or is that being dealt with elsewhere?

This is related to what @hungvu193 pointed out here too - fixed.

I think all the single input screens (legal name, job title) need to autofocus the input when you get to them (for the first time or any subsequent time)—that's how we typically handle inputs like that

Added autofocus to sile input screens.

burczu · 2024-11-13T11:10:37Z

@shawnborton Answering your comments:

Feeling good! I have the same feedback as Danny above regarding the checkbox size.

Then for this screen, the blue link looks like it's not left-aligned the same way the others are:

Good point. Fixed.

Then for this screen, it feels like the input could be a bit closer to the headline?

Yes. Fixed

burczu · 2024-11-13T11:41:44Z

@hungvu193 I think I've addressed all the comments - you can now re-review the PR. Videos also are updated now.

hungvu193 · 2024-11-14T02:36:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-11.at.13.32.38.mov

Android: mWeb Chrome

Screen.Recording.2024-11-11.at.11.18.32.mov

iOS: Native

Screen.Recording.2024-11-11.at.11.10.09.mov

iOS: mWeb Safari

Screen.Recording.2024-11-11.at.10.56.48.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-11.at.10.47.27.mov

MacOS: Desktop

Screen.Recording.2024-11-11.at.10.46.15.mov

hungvu193 · 2024-11-14T02:38:10Z

@burczu LGTM. I think we only have translations left

…reen

burczu · 2024-11-14T08:24:14Z

@hungvu193 asked for confirmation on translations here: https://callstack-hq.slack.com/archives/C01GTK53T8Q/p1731572554005439

burczu · 2024-11-14T10:27:39Z

@hungvu193 spanish translations reviewed and updated

hungvu193

LGTM

…reen

madmax330 · 2024-11-14T11:11:33Z

src/pages/ReimbursementAccount/NonUSD/WhyLink.tsx

+    containerStyles?: StyleProp<ViewStyle>;
+};
+
+function WhyLink({containerStyles}: WhyLinkProps) {


This component was already added in @pasyukevich's PR here: https://github.com/Expensify/App/pull/52054/files

Oh It was merged recently, I didn't notice it during this PR review process

yeah, it disappeared from this PR after I've synced it with the latest main

…reen

burczu force-pushed the feat/50901-GR-step-5-director-information-screen branch 4 times, most recently from 040bcf1 to f1c90fa Compare November 5, 2024 07:41

burczu added 8 commits November 6, 2024 07:10

enter email, hang tight and director check components added

597791a

basic sub-steps components added

7b4a37b

signer info implementation

063afb0

name sub-step refactored to use common step component

28c97bc

job title component refactored using common single step comp.

1ce8269

refactor: showing footer component in date of birth step instead fixe…

e7bcee1

…d help links

date of birth using common step component

36075f4

confirmation refactored using common step component

d7fd35e

burczu force-pushed the feat/50901-GR-step-5-director-information-screen branch from f1c90fa to d7fd35e Compare November 6, 2024 06:10

burczu added 2 commits November 6, 2024 07:54

upload document ID's issue fixed

bb61094

prettier

69ae3bb

burczu marked this pull request as ready for review November 6, 2024 12:02

burczu requested review from a team as code owners November 6, 2024 12:02

melvin-bot bot requested a review from hungvu193 November 6, 2024 12:02

melvin-bot bot removed the request for review from a team November 6, 2024 12:02

Merge branch 'main' into feat/50901-GR-step-5-director-information-sc…

5170612

…reen

radio buttons styling fix

8f36161

hungvu193 reviewed Nov 11, 2024

View reviewed changes

Merge branch 'main' into feat/50901-GR-step-5-director-information-sc…

3df05c4

…reen

upload file styling fixed

2971a7b

burczu added 4 commits November 13, 2024 11:39

yes or no step component extracted

3906419

bottom link styles fixed

e16db0f

single field spacing fixed

33f6ae2

autofocus added

4115182

hungvu193 mentioned this pull request Nov 14, 2024

feat: Step 4 UI #52384

Open

49 tasks

burczu added 2 commits November 14, 2024 08:56

Merge branch 'main' into feat/50901-GR-step-5-director-information-sc…

d350696

…reen

translations fixed

8f03cf7

spanish translations updated

ceca5bb

hungvu193 approved these changes Nov 14, 2024

View reviewed changes

melvin-bot bot requested a review from madmax330 November 14, 2024 10:30

Merge branch 'main' into feat/50901-GR-step-5-director-information-sc…

23e1721

…reen

madmax330 reviewed Nov 14, 2024

View reviewed changes

upload file style fix

418fbd7

burczu force-pushed the feat/50901-GR-step-5-director-information-screen branch from fcd83e9 to 418fbd7 Compare November 14, 2024 12:30

Merge branch 'main' into feat/50901-GR-step-5-director-information-sc…

884a42a

…reen

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GR Phase 2] Step 5 Director information screen (without API calls) - implementation #51648

[GR Phase 2] Step 5 Director information screen (without API calls) - implementation #51648

burczu commented Oct 29, 2024 •

edited

Loading

melvin-bot bot commented Nov 6, 2024

dannymcclain commented Nov 6, 2024

shawnborton commented Nov 6, 2024 •

edited

Loading

dubielzyk-expensify commented Nov 7, 2024 •

edited

Loading

hungvu193 commented Nov 8, 2024

burczu commented Nov 8, 2024

hungvu193 commented Nov 11, 2024 •

edited

Loading

burczu commented Nov 13, 2024

burczu commented Nov 13, 2024

hungvu193 commented Nov 13, 2024

hungvu193 commented Nov 13, 2024

burczu commented Nov 13, 2024

hungvu193 commented Nov 13, 2024

burczu commented Nov 13, 2024

burczu commented Nov 13, 2024

burczu commented Nov 13, 2024

hungvu193 commented Nov 14, 2024

hungvu193 commented Nov 14, 2024

burczu commented Nov 14, 2024

burczu commented Nov 14, 2024

hungvu193 left a comment

madmax330 Nov 14, 2024

hungvu193 Nov 14, 2024

burczu Nov 14, 2024

[GR Phase 2] Step 5 Director information screen (without API calls) - implementation #51648

Are you sure you want to change the base?

[GR Phase 2] Step 5 Director information screen (without API calls) - implementation #51648

Conversation

burczu commented Oct 29, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 6, 2024

dannymcclain commented Nov 6, 2024

shawnborton commented Nov 6, 2024 • edited Loading

dubielzyk-expensify commented Nov 7, 2024 • edited Loading

hungvu193 commented Nov 8, 2024

burczu commented Nov 8, 2024

hungvu193 commented Nov 11, 2024 • edited Loading

burczu commented Nov 13, 2024

burczu commented Nov 13, 2024

hungvu193 commented Nov 13, 2024

hungvu193 commented Nov 13, 2024

burczu commented Nov 13, 2024

hungvu193 commented Nov 13, 2024

burczu commented Nov 13, 2024

burczu commented Nov 13, 2024

burczu commented Nov 13, 2024

hungvu193 commented Nov 14, 2024

Reviewer Checklist

Screenshots/Videos

hungvu193 commented Nov 14, 2024

burczu commented Nov 14, 2024

burczu commented Nov 14, 2024

hungvu193 left a comment

Choose a reason for hiding this comment

madmax330 Nov 14, 2024

Choose a reason for hiding this comment

hungvu193 Nov 14, 2024

Choose a reason for hiding this comment

burczu Nov 14, 2024

Choose a reason for hiding this comment

burczu commented Oct 29, 2024 •

edited

Loading

shawnborton commented Nov 6, 2024 •

edited

Loading

dubielzyk-expensify commented Nov 7, 2024 •

edited

Loading

hungvu193 commented Nov 11, 2024 •

edited

Loading